netdev - Re: [Patch net-next 1/3] ipv4: fail early when creating netdev named all or default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpUs3Js2Gjmmj+dEMxQTHOQFSEZCyos=1b=peU4-3Rf5vg@mail.gmail.com>
Date:	Thu, 24 Jul 2014 10:41:46 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Andy Gospodarek <gospo@...ulusnetworks.com>
Cc:	Florian Fainelli <f.fainelli@...il.com>,
	netdev <netdev@...r.kernel.org>,
	Stephane Chazelas <stephane.chazelas@...il.com>,
	David Miller <davem@...emloft.net>
Subject: Re: [Patch net-next 1/3] ipv4: fail early when creating netdev named
 all or default

On Wed, Jul 23, 2014 at 8:00 PM, Andy Gospodarek
<gospo@...ulusnetworks.com> wrote:
> On Wed, Jul 23, 2014 at 06:05:07PM -0700, Florian Fainelli wrote:
>>
>> Since this exact same check is done in the ipv6 counterpart, how about
>> moving this to a helper function like: sysctl_dev_name_is_allowed()
>> such that you centralize where the naming policy is enforced? In case
>> we need to blacklist some other interface names, there should be one
>> place to update.
>
> Agree that a common function would be useful.
>
> There also might be cases where one would want to impose more limits
> than just what is limited based on /proc, so this may be something to consider
> in core networking code.

I agree generally, just that I think each protocol should be free to define
its own limit on names, not just "all" and "default".

Anyway, I will wait for other feedback, especially from David,
and update the patch.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html