netdev - Re: [net-next 14/14] i40e: always print aqtx answer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1406231761.27221.65.camel@joe-AO725>
Date:	Thu, 24 Jul 2014 12:56:01 -0700
From:	Joe Perches <joe@...ches.com>
To:	"Nelson, Shannon" <shannon.nelson@...el.com>
Cc:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"nhorman@...hat.com" <nhorman@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>
Subject: Re: [net-next 14/14] i40e: always print aqtx answer

On Thu, 2014-07-24 at 19:20 +0000, Nelson, Shannon wrote:
> > From: Joe Perches [mailto:joe@...ches.com]
> > Sent: Thursday, July 24, 2014 11:43 AM
> > 
> > On Thu, 2014-07-24 at 06:13 -0700, Jeff Kirsher wrote:
> > > From: Shannon Nelson <shannon.nelson@...el.com>
> > >
> > > Sometimes the AQTX answer comes back with no data, but we still want
> > to print
> > > the descriptor that got written back.
> > 
> > Maybe this does some reads from buffer beyond its size
> > in i40e_debug_aq?  Is that always safe?
> 
> This is safe because we'll only print the descriptor in this case, not the buffer.  There's a check in i40e_debug_aq() for NULL or zero-length buffer.

The question is not for descriptor length 0 or null,
but bad descriptor length.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html