netdev - Re: [PATCH v2 net] ip: make IP identifiers less predictable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1406318067.3363.108.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Fri, 25 Jul 2014 21:54:27 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>,
	Jeffrey Knockel <jeffk@...unm.edu>,
	"Jedidiah R. Crandall" <crandall@...unm.edu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Willy Tarreau <w@....eu>, security@...nel.org
Subject: Re: [PATCH v2 net] ip: make IP identifiers less predictable

On Fri, 2014-07-25 at 21:50 +0200, Eric Dumazet wrote:

> @@ -1092,6 +1093,7 @@ static inline int ip6_ufo_append_data(struct sock *sk,
>  	skb_shinfo(skb)->gso_size = (mtu - fragheaderlen -
>  				     sizeof(struct frag_hdr)) & ~7;
>  	skb_shinfo(skb)->gso_type = SKB_GSO_UDP;
> +	fhdr.nexthdr = IPPROTO_UDP;
>  	ipv6_select_ident(&fhdr, rt);
>  	skb_shinfo(skb)->ip6_frag_id = fhdr.identification;
>  
> 
> 

Arg, please ignore this version, this part is buggy.

I think I wont hash on ipv6 saddr, we might add this later.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html