netdev - Re: [PATCH net-next 5/9] inet: frag: don't account number of fragment queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140725083205.GG18404@breakpoint.cc>
Date:	Fri, 25 Jul 2014 10:32:05 +0200
From:	Florian Westphal <fw@...len.de>
To:	David Miller <davem@...emloft.net>
Cc:	nikolay@...hat.com, netdev@...r.kernel.org, fw@...len.de,
	kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	kaber@...sh.net, alex.aring@...il.com, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 5/9] inet: frag: don't account number of
 fragment queues

David Miller <davem@...emloft.net> wrote:
> From: Nikolay Aleksandrov <nikolay@...hat.com>
> Date: Thu, 24 Jul 2014 16:50:33 +0200
> 
> > From: Florian Westphal <fw@...len.de>
> > 
> > The 'nqueues' counter is protected by the lru list lock,
> > once thats removed this needs to be converted to atomic
> > counter.  Given this isn't used for anything except for
> > reporting it to userspace via /proc, just remove it.
> > 
> > We still report the memory currently used by fragment
> > reassembly queues.
> > 
> > Signed-off-by: Florian Westphal <fw@...len.de>
> 
> It's a user visible value, you can't just change it's semantics.

Really?  It won't break scripts.
In my tests this never reported any useful information to me.

If you insist, we can keep this but it seems silly to me to add atomic
ops just for this one counter which - IMO - does not provide
any useful information.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html