netdev - Re: [PATCHv3] skbedit: allow the user to specify bitmask for mark

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140724.180708.1613882522982264262.davem@davemloft.net>
Date:	Thu, 24 Jul 2014 18:07:08 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	antonio@...hcoding.com
Cc:	netdev@...r.kernel.org, sergei.shtylyov@...entembedded.com,
	eric.dumazet@...il.com, cwang@...pensource.com,
	antonio@...n-mesh.com, jhs@...atatu.com
Subject: Re: [PATCHv3] skbedit: allow the user to specify bitmask for mark

From: David Miller <davem@...emloft.net>
Date: Thu, 24 Jul 2014 18:03:23 -0700 (PDT)

> From: Antonio Quartulli <antonio@...hcoding.com>
> Date: Wed, 23 Jul 2014 21:13:35 +0200
> 
>> From: Antonio Quartulli <antonio@...n-mesh.com>
>> 
>> The user may want to use only some bits of the skb mark in
>> his skbedit rules because the remaining part might be used by
>> something else.
>> 
>> Introduce the "mask" parameter to the skbedit actor in order
>> to implement such functionality.
>> 
>> When the mask is specified, only those bits selected by the
>> latter are altered really changed by the actor, while the
>> rest is left untouched.
>> 
>> Signed-off-by: Antonio Quartulli <antonio@...n-mesh.com>
>> Signed-off-by: Jamal Hadi Salim <jhs@...atatu.com>
> 
> Applied, thank you.

Actually reverted, it doesn't even build:

+	if ((d->flags & SKBEDIT_F_MASK) &&
+	    nla_put_u32(skb, TCA_SKBEDIT_MASK, d->mask);

How did you test this?

You didn't even compile this code.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html