netdev - Re: [PATCH net-next 2/3] ethtool: add rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.03.1407261603450.3407@ws.cisco>
Date:	Sat, 26 Jul 2014 16:19:16 +0530 (IST)
From:	Govindarajulu Varadarajan <_govind@....com>
To:	Ben Hutchings <ben@...adent.org.uk>, davem@...emloft.net
cc:	Govindarajulu Varadarajan <_govind@....com>,
	netdev@...r.kernel.org, ssujith@...co.com, benve@...co.com
Subject: Re: [PATCH net-next 2/3] ethtool: add rx_copybreak support

On Wed, 23 Jul 2014, Govindarajulu Varadarajan wrote:

> On Tue, 22 Jul 2014, Ben Hutchings wrote:
>> No, you can't do that either.  Basically you can't change the size or
>> layout of any of the ethtool structures.
>
> Ok. Can you suggest me how I should add rx_copybreak to ethtool?
>
> May be add another function, set/get_rxcopybreak(), to ethtool_ops?
>
> Thanks
>

Should I drop the idea of ethtool and resubmit just the rx_copybreak changes?
(use module parameter to change rx_copybreak value).

Or should I try something like this
3de0b592394d17b 'ethtool: Support for configurable RSS hash key', Create new
ethtool cmd for changing driver rx_copybreak value.

Thanks
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html