netdev - Re: [PATCH] ip_tunnel(ipv4): fix tunnels with "local any remote $remote

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140728.164432.336779387487870757.davem@davemloft.net>
Date:	Mon, 28 Jul 2014 16:44:32 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	cwang@...pensource.com
Cc:	ixaphire@...tor.net, netdev@...r.kernel.org, pinkbyte@...too.org,
	edumazet@...gle.com, therbert@...gle.com
Subject: Re: [PATCH] ip_tunnel(ipv4): fix tunnels with "local any remote
 $remote_ip"

From: Cong Wang <cwang@...pensource.com>
Date: Mon, 28 Jul 2014 16:39:23 -0700

> On Mon, Jul 28, 2014 at 4:07 PM, Dmitry Popov <ixaphire@...tor.net> wrote:
>> --- a/include/net/ip_tunnels.h
>> +++ b/include/net/ip_tunnels.h
>> @@ -40,6 +40,7 @@ struct ip_tunnel_prl_entry {
>>
>>  struct ip_tunnel_dst {
>>         struct dst_entry __rcu          *dst;
>> +       __be32                           saddr;
>>  };
> 
> 
> It looks odd to save a source address in some struct named dst,
> maybe it's the time to rename it.

It's an encapsulation struct for plain "struct dst_entry", which is a
path to a destination, or in other words a "route".  A "saddr" is a
valid key for a route.

I see no reason to change the name of this structure, it's perfect.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html