netdev - Re: [PATCH net v2] net: phy: re-apply PHY fixups during phy_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140729.122626.714394251453806579.davem@davemloft.net>
Date:	Tue, 29 Jul 2014 12:26:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	netdev@...r.kernel.org, jogo@...nwrt.org, hauke@...ke-m.de
Subject: Re: [PATCH net v2] net: phy: re-apply PHY fixups during
 phy_register_device

From: Florian Fainelli <f.fainelli@...il.com>
Date: Mon, 28 Jul 2014 16:28:07 -0700

> Commit 87aa9f9c61ad ("net: phy: consolidate PHY reset in phy_init_hw()")
> moved the call to phy_scan_fixups() in phy_init_hw() after a software
> reset is performed.
> 
> By the time phy_init_hw() is called in phy_device_register(), no driver
> has been bound to this PHY yet, so all the checks in phy_init_hw()
> against the PHY driver and the PHY driver's config_init function will
> return 0. We will therefore never call phy_scan_fixups() as we should.
> 
> Fix this by calling phy_scan_fixups() and check for its return value to
> restore the intended functionality.
> 
> This broke PHY drivers which do register an early PHY fixup callback to
> intercept the PHY probing and do things like changing the 32-bits unique
> PHY identifier when a pseudo-PHY address has been used, as well as
> board-specific PHY fixups that need to be applied during driver probe
> time.
> 
> Reported-by: Hauke Merthens <hauke-m@...ke-m.de>
> Reported-by: Jonas Gorski <jogo@...nwrt.org>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
> Changes in v2:
> - call phy_scan_fixups directly since this is what we are interested in
> - check the phy_scan_fixups return value
> 
> Applicable for 3.14+

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html