[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20140729.153048.1378087192291832153.davem@davemloft.net>
Date: Tue, 29 Jul 2014 15:30:48 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: ben@...adent.org.uk
Cc: sshah@...arflare.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] sfc: Use __iowrite64_copy instead of a
slightly different local function
From: Ben Hutchings <ben@...adent.org.uk>
Date: Sun, 27 Jul 2014 03:14:39 +0100
> __iowrite64_copy() isn't quite the same as efx_memcpy_64(), but
> it looks close enough:
>
> - The length is in units of qwords not bytes
> - It never byte-swaps, but that doesn't make a difference now as PIO
> is only enabled for x86_64
> - It doesn't include any memory barriers, but that's OK as there is a
> barrier just before pushing the doorbell
> - mlx4_en uses it for the same purpose
>
> Compile-tested only.
>
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists