netdev - Re: [PATCH net 1/1] tipc: make tipc_buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140728.183423.698426909730741975.davem@davemloft.net>
Date:	Mon, 28 Jul 2014 18:34:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jon.maloy@...csson.com
Cc:	netdev@...r.kernel.org, paul.gortmaker@...driver.com,
	erik.hugne@...csson.com, ying.xue@...driver.com, maloy@...jonn.com,
	tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net 1/1] tipc: make tipc_buf_append() more robust

From: Jon Maloy <jon.maloy@...csson.com>
Date: Fri, 25 Jul 2014 14:48:09 -0400

> As per comment from David Miller, we try to make the buffer reassembly
> function more resilient to user errors than it is today.
> 
> - We check that the "*buf" parameter always is set, since this is
>   mandatory input.
> 
> - We ensure that *buf->next always is set to NULL before linking in
>   the buffer, instead of relying of the caller to have done this.
> 
> - We ensure that the "tail" pointer in the head buffer's control
>   block is initialized to NULL when the first fragment arrives.
> 
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>

Applied to net-next, since this doesn't really fix any bugs.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html