netdev - Re: [PATCH v2 net] tcp: Fix integer-overflows in TCP vegas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140728.172627.1679434888082672835.davem@davemloft.net>
Date:	Mon, 28 Jul 2014 17:26:27 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	christoph.paasch@...ouvain.be
Cc:	netdev@...r.kernel.org, ncardwell@...gle.com,
	David.Laight@...LAB.COM, doug.leith@...m.ie
Subject: Re: [PATCH v2 net] tcp: Fix integer-overflows in TCP vegas

From: Christoph Paasch <christoph.paasch@...ouvain.be>
Date: Fri, 25 Jul 2014 13:52:39 +0200

> +				target_cwnd = U32_MAX / rtt * upper + err / rtt;

Doing two divides is probably more expensive than using do_div().

Why don't we go back to the do_div() implementation, sorry about
changing my mind again.

And please resubmit the veno change, it's fine as-is.

Thanks again.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html