netdev - Re: Re: [PATCH net-next] pktgen: add ttl option for pktgen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 30 Jul 2014 20:49:21 +0800 (GMT+08:00)
From:	"Zhouyi Zhou" <yizhouzhou@....ac.cn>
To:	"Dmitry Popov" <ixaphire@...tor.net>
Cc:	"Zhouyi Zhou" <zhouzhouyi@...il.com>, rdunlap@...radead.org,
	davem@...emloft.net, minipli@...glemail.com, brouer@...hat.com,
	steffen.klassert@...unet.com, fan.du@...driver.com,
	dborkman@...hat.com, fengguang.wu@...el.com, tgraf@...g.ch,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: Re: [PATCH net-next] pktgen: add ttl option for pktgen

Thanks for reviewing.
I did miss it.
> -----Original Messages-----
> From: "Dmitry Popov" <ixaphire@...tor.net>
> Sent Time: Wednesday, July 30, 2014
> To: "Zhouyi Zhou" <zhouzhouyi@...il.com>
> Cc: rdunlap@...radead.org, davem@...emloft.net, minipli@...glemail.com, brouer@...hat.com, steffen.klassert@...unet.com, fan.du@...driver.com, dborkman@...hat.com, fengguang.wu@...el.com, tgraf@...g.ch, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, "Zhouyi Zhou" <yizhouzhou@....ac.cn>
> Subject: Re: [PATCH net-next] pktgen: add ttl option for pktgen
> 
> On Wed, 30 Jul 2014 16:21:26 +0800
> Zhouyi Zhou <zhouzhouyi@...il.com> wrote:
> 
> > I think it is useful to add ttl option for pktgen, for example
> > if a some ISP want to test its network quality, it could set 
> > ttl so that the tested links get the packet while end users won't
> > get it. 
> 
> It seems you're missing 
> 
> --- a/net/core/pktgen.c
> +++ b/net/core/pktgen.c
> @@ -2799,7 +2799,7 @@ static struct sk_buff *fill_packet_ipv4(struct net_device *odev,
> 
>     iph->ihl = 5;
>     iph->version = 4;
> -   iph->ttl = 32;
> +   iph->ttl = pkt_dev->ttl;
>     iph->tos = pkt_dev->tos;
>     iph->protocol = IPPROTO_UDP;    /* UDP */
>     iph->saddr = pkt_dev->cur_saddr;




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html