netdev - Re: Fwd: Re: GRO issue with kernel 3.4.94 (icmp fragmentation needed)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Jul 2014 17:22:55 -0700
From:	Greg KH <greg@...ah.com>
To:	Thomas Jarosch <thomas.jarosch@...ra2net.com>
Cc:	netdev@...r.kernel.org, Florian Westphal <fw@...len.de>
Subject: Re: Fwd: Re: GRO issue with kernel 3.4.94 (icmp fragmentation needed)

On Fri, Jul 11, 2014 at 05:12:55PM +0200, Thomas Jarosch wrote:
> Hi Greg,
> 
> I don't have the original patch email, but please include
> the mentioned commit
> 
> ------------------------------------------
> commit 21d1196a35f5686c4323e42a62fdb4b23b0ab4a3
> Author: Eric Dumazet <edumazet@...gle.com>
> ipv4: set transport header earlier
> ------------------------------------------
> 
> in the 3.4.x stable tree.
> 
> After updating from 3.4.91 to 3.4.96, TCP connections
> from Windows 7 clients slowed down to a crawl.
> (to be precise: totally unusable)
> 
> The commit recommended by Florian Westphal fixes it immediately.
> 
> Best regards,
> Thomas
> 
> ----------  Forwarded Message  ----------
> 
> Subject: Re: GRO issue with kernel 3.4.94 (icmp fragmentation needed)
> Date: Friday, 27. June 2014, 11:05:25
> From: Florian Westphal <fw@...len.de>
> To: jungwon park <jwpark2@...tecode.co.kr>
> CC: netdev@...r.kernel.org
> 
> jungwon park <jwpark2@...tecode.co.kr> wrote:
> > When using the linux router is turned on GRO, router send the 
> 'fragmentation
> > needed' packets to the sender.
> 
> Indeed 8-(
> 
> > When I turned off GRO, the router operate normally, and there is no 
> problem.
> > and with 3.4.91 kernel, the router has no problem.
> > 
> > I doubt 'ipv4: ip_forward: fix inverted local_df test' patch.
> > (http://patchwork.ozlabs.org/patch/345509/)
> > When I revert this patch, the router has no problem.
> 
> Can you please cherry-pick following patch on top of vanilla 3.4.92?
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=21d1196a35f5686c4323e42a62fdb4b23b0ab4a3
> 
> commit 21d1196a35f5686c4323e42a62fdb4b23b0ab4a3
> Author: Eric Dumazet <edumazet@...gle.com>
> ipv4: set transport header earlier
> 
> I think that should fix this bug, it should apply cleanly on top of
> 3.4.y tree.
> 
> [ patch is in 3.11, also backported to 3.10.y tree ]
> 
> The problem is that, when dealing with GRO packets, we try to determine
> the size of the individual packets.  To do this, we rely on the
> transport header.
> 
> Unfortunately the transport header is not set for the forward path in 3.4,
> so we look at the network header instead.

Why would this patch matter, as commit 45f00f99d6e, which this patch
fixes, is not in the 3.4-stable tree at all.

Also, network stable patches need to go through the network maintainer,
not me directly.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html