lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Jul 2014 18:12:35 +0200 From: Hannes Frederic Sowa <hannes@...essinduktion.org> To: David Lamparter <equinox@...c24.net> Cc: netdev@...r.kernel.org, Stephen Hemminger <stephen@...workplumber.org>, Jiri Pirko <jiri@...nulli.us> Subject: Re: [RFC alternate] ipv6: addrconf: clean up device type handling On Mi, 2014-07-30 at 17:58 +0200, David Lamparter wrote: > This realigns addrconf support for the various lower-layer device types, > and removes a little bit of duplicate code. > > For GRE devices, this includes a semantic change in that there is now a > ff00::/8 route installed on address autogeneration. This was previously > missing and broke any kind of IPv6 multicast - unless another address > was configured from userspace (which then added the missing ff00::/8). > > Fixes: aee80b54b235 (ipv6: generate link local address for GRE tunnel) > Signed-off-by: David Lamparter <equinox@...c24.net> > Cc: Hannes Frederic Sowa <hannes@...essinduktion.org> > Cc: Stephen Hemminger <stephen@...workplumber.org> > Cc: Jiri Pirko <jiri@...nulli.us> > --- > > This is an alternate version, yanking the switch() down and removing > dev_config/gre_config duplication. I have no idea what rationale is behind > prefix_route - the result is a fe80::/64 route, but no address, which is not a > functioning configuration. Jiri, you touched this just a few weeks ago, can > you comment? (The "XXX: why is GRE special?") Sure, it is valid. You can still use global addresses to talk to link local addresses on the same link, even from another interface. I prefer this patch. Thanks, Hannes -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists