netdev - Re: [PATCH net-next 1/3] mlx5: Move pci device handling from mlx5_ib to mlx5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZOPZJPQNH5Nxg0hrrfSfV05ALqH3SdV0=dHYKq9jduivMS1g@mail.gmail.com>
Date:	Wed, 30 Jul 2014 23:57:51 +0300
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	Eli Cohen <eli@....mellanox.co.il>
Cc:	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Roland Dreier <roland@...nel.org>,
	Jack Morgenstein <jackm@....mellanox.co.il>,
	Eli Cohen <eli@...lanox.com>,
	Yevgeny Petrilin <yevgenyp@...lanox.com>
Subject: Re: [PATCH net-next 1/3] mlx5: Move pci device handling from mlx5_ib
 to mlx5_core

On Wed, Jul 30, 2014 at 1:26 PM, Eli Cohen <eli@....mellanox.co.il> wrote:
>
> On Mon, Jul 28, 2014 at 11:57:37PM +0300, Or Gerlitz wrote:
> >
> > You need to issue a warning here if someone attempts to change the
> > previously default value of the now deprecated module param. E.g warn
> > this is deprecated and point them to mlx5_core
> >
>
> It is handled in the module init function:



Oh, I see it now, well done.

Or.

>
>
> static int __init mlx5_ib_init(void)
> {
> -       return pci_register_driver(&mlx5_ib_driver);
> +       if (deprecated_prof_sel != 2)
> +               pr_warn("prof_sel is deprecated for mlx5_ib, set it
> for mlx5_core\n");
> +
> +       return mlx5_register_interface(&mlx5_ib_interface);
> }
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html