lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Jul 2014 17:01:05 -0700 From: John Stultz <john.stultz@...aro.org> To: linux-kernel@...r.kernel.org Cc: John Stultz <john.stultz@...aro.org>, Stephen Rothwell <sfr@...b.auug.org.au>, Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>, Peter Zijlstra <peterz@...radead.org>, David Miller <davem@...emloft.net>, "John W. Linville" <linville@...driver.com>, Felix Fietkau <nbd@...nwrt.org>, Rajkumar Manoharan <rmanohar@....qualcomm.com>, <netdev@...r.kernel.org>, QCA ath9k Development <ath9k-devel@....qualcomm.com>, linux-next@...r.kernel.org Subject: [RFC][PATCH] wireless: ath9k: Convert from timespecs to ktime_t Convert from using timespecs to ktime_t for internal timekeeping needs. This simplifies the logic and avoids extra math required to convert from timespec to usecs. Cc: Stephen Rothwell <sfr@...b.auug.org.au> Cc: Ingo Molnar <mingo@...e.hu> Cc: "H. Peter Anvin" <hpa@...or.com> Cc: Peter Zijlstra <peterz@...radead.org> Cc: David Miller <davem@...emloft.net> Cc: "John W. Linville" <linville@...driver.com> Cc: Felix Fietkau <nbd@...nwrt.org> Cc: Rajkumar Manoharan <rmanohar@....qualcomm.com> Cc: <netdev@...r.kernel.org> Cc: QCA ath9k Development <ath9k-devel@....qualcomm.com> Cc: linux-next@...r.kernel.org Signed-off-by: John Stultz <john.stultz@...aro.org> --- Thomas made an earlier version of this patch which I queued, but it collided badly in -next with the timestamping rework in ath9k code. So this is my swing at fixing it up again. Compile tested only. Would apprecate feedback and review. drivers/net/wireless/ath/ath9k/ath9k.h | 2 +- drivers/net/wireless/ath/ath9k/channel.c | 18 +++++++++--------- drivers/net/wireless/ath/ath9k/hw.c | 19 +++++++------------ drivers/net/wireless/ath/ath9k/hw.h | 2 +- drivers/net/wireless/ath/ath9k/main.c | 2 +- 5 files changed, 19 insertions(+), 24 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/ath9k.h b/drivers/net/wireless/ath/ath9k/ath9k.h index 7fc13a8..5553c0f 100644 --- a/drivers/net/wireless/ath/ath9k/ath9k.h +++ b/drivers/net/wireless/ath/ath9k/ath9k.h @@ -335,7 +335,7 @@ struct ath_chanctx { struct ath_beacon_config beacon; struct ath9k_hw_cal_data caldata; - struct timespec tsf_ts; + ktime_t tsf_kt; u64 tsf_val; u32 last_beacon; diff --git a/drivers/net/wireless/ath/ath9k/channel.c b/drivers/net/wireless/ath/ath9k/channel.c index ba214eb..2b37f8d 100644 --- a/drivers/net/wireless/ath/ath9k/channel.c +++ b/drivers/net/wireless/ath/ath9k/channel.c @@ -228,9 +228,9 @@ static bool ath_chanctx_defer_switch(struct ath_softc *sc) static void ath_chanctx_set_next(struct ath_softc *sc, bool force) { - struct timespec ts; bool measure_time = false; bool send_ps = false; + ktime_t now; spin_lock_bh(&sc->chan_lock); if (!sc->next_chan) { @@ -248,7 +248,7 @@ static void ath_chanctx_set_next(struct ath_softc *sc, bool force) spin_unlock_bh(&sc->chan_lock); if (sc->next_chan == &sc->offchannel.chan) { - getrawmonotonic(&ts); + now = ktime_get_raw(); measure_time = true; } __ath9k_flush(sc->hw, ~0, true); @@ -260,7 +260,7 @@ static void ath_chanctx_set_next(struct ath_softc *sc, bool force) spin_lock_bh(&sc->chan_lock); if (sc->cur_chan != &sc->offchannel.chan) { - getrawmonotonic(&sc->cur_chan->tsf_ts); + sc->cur_chan->tsf_kt = ktime_get_raw(); sc->cur_chan->tsf_val = ath9k_hw_gettsf64(sc->sc_ah); } } @@ -279,7 +279,7 @@ static void ath_chanctx_set_next(struct ath_softc *sc, bool force) ath_set_channel(sc); if (measure_time) sc->sched.channel_switch_time = - ath9k_hw_get_tsf_offset(&ts, NULL); + ath9k_hw_get_tsf_offset(&now, NULL); } if (send_ps) ath_chanctx_send_ps_frame(sc, false); @@ -440,8 +440,8 @@ ath_chanctx_get_next(struct ath_softc *sc, struct ath_chanctx *ctx) static void ath_chanctx_adjust_tbtt_delta(struct ath_softc *sc) { struct ath_chanctx *prev, *cur; - struct timespec ts; u32 cur_tsf, prev_tsf, beacon_int; + ktime_t now; s32 offset; beacon_int = TU_TO_USEC(sc->cur_chan->beacon.beacon_interval); @@ -449,12 +449,12 @@ static void ath_chanctx_adjust_tbtt_delta(struct ath_softc *sc) cur = sc->cur_chan; prev = ath_chanctx_get_next(sc, cur); - getrawmonotonic(&ts); + now = ktime_get_raw(); cur_tsf = (u32) cur->tsf_val + - ath9k_hw_get_tsf_offset(&cur->tsf_ts, &ts); + ath9k_hw_get_tsf_offset(&cur->tsf_kt, &now); prev_tsf = prev->last_beacon - (u32) prev->tsf_val + cur_tsf; - prev_tsf -= ath9k_hw_get_tsf_offset(&prev->tsf_ts, &ts); + prev_tsf -= ath9k_hw_get_tsf_offset(&prev->tsf_kt, &now); /* Adjust the TSF time of the AP chanctx to keep its beacons * at half beacon interval offset relative to the STA chanctx. @@ -614,7 +614,7 @@ void ath_chanctx_event(struct ath_softc *sc, struct ieee80211_vif *vif, */ tsf_time = sc->sched.switch_start_time; tsf_time -= (u32) sc->cur_chan->tsf_val + - ath9k_hw_get_tsf_offset(&sc->cur_chan->tsf_ts, NULL); + ath9k_hw_get_tsf_offset(&sc->cur_chan->tsf_kt, NULL); tsf_time += ath9k_hw_gettsf32(ah); diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c index fd0158f..d15f48e 100644 --- a/drivers/net/wireless/ath/ath9k/hw.c +++ b/drivers/net/wireless/ath/ath9k/hw.c @@ -1731,19 +1731,14 @@ fail: return -EINVAL; } -u32 ath9k_hw_get_tsf_offset(struct timespec *last, struct timespec *cur) +u32 ath9k_hw_get_tsf_offset(ktime_t *last, ktime_t *cur) { - struct timespec ts; s64 usec; - if (!cur) { - getrawmonotonic(&ts); - cur = &ts; - } - - usec = cur->tv_sec * 1000000ULL + cur->tv_nsec / 1000; - usec -= last->tv_sec * 1000000ULL + last->tv_nsec / 1000; + if (!cur) + *cur = ktime_get_raw(); + usec = ktime_to_us(ktime_sub(*cur, *last)); return (u32) usec; } EXPORT_SYMBOL(ath9k_hw_get_tsf_offset); @@ -1752,7 +1747,7 @@ int ath9k_hw_reset(struct ath_hw *ah, struct ath9k_channel *chan, struct ath9k_hw_cal_data *caldata, bool fastcc) { struct ath_common *common = ath9k_hw_common(ah); - struct timespec ts; + ktime_t now; u32 saveLedState; u32 saveDefAntenna; u32 macStaId1; @@ -1801,7 +1796,7 @@ int ath9k_hw_reset(struct ath_hw *ah, struct ath9k_channel *chan, /* Save TSF before chip reset, a cold reset clears it */ tsf = ath9k_hw_gettsf64(ah); - getrawmonotonic(&ts); + now = ktime_get_raw(); saveLedState = REG_READ(ah, AR_CFG_LED) & (AR_CFG_LED_ASSOC_CTL | AR_CFG_LED_MODE_SEL | @@ -1834,7 +1829,7 @@ int ath9k_hw_reset(struct ath_hw *ah, struct ath9k_channel *chan, } /* Restore TSF */ - ath9k_hw_settsf64(ah, tsf + ath9k_hw_get_tsf_offset(&ts, NULL)); + ath9k_hw_settsf64(ah, tsf + ath9k_hw_get_tsf_offset(&now, NULL)); if (AR_SREV_9280_20_OR_LATER(ah)) REG_SET_BIT(ah, AR_GPIO_INPUT_EN_VAL, AR_GPIO_JTAG_DISABLE); diff --git a/drivers/net/wireless/ath/ath9k/hw.h b/drivers/net/wireless/ath/ath9k/hw.h index 51b4ebe..a57b4e2 100644 --- a/drivers/net/wireless/ath/ath9k/hw.h +++ b/drivers/net/wireless/ath/ath9k/hw.h @@ -1000,7 +1000,7 @@ u32 ath9k_hw_gettsf32(struct ath_hw *ah); u64 ath9k_hw_gettsf64(struct ath_hw *ah); void ath9k_hw_settsf64(struct ath_hw *ah, u64 tsf64); void ath9k_hw_reset_tsf(struct ath_hw *ah); -u32 ath9k_hw_get_tsf_offset(struct timespec *last, struct timespec *cur); +u32 ath9k_hw_get_tsf_offset(ktime_t *last, ktime_t *cur); void ath9k_hw_set_tsfadjust(struct ath_hw *ah, bool set); void ath9k_hw_init_global_settings(struct ath_hw *ah); u32 ar9003_get_pll_sqsum_dvc(struct ath_hw *ah); diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c index e6ac8d2..e47dbd3 100644 --- a/drivers/net/wireless/ath/ath9k/main.c +++ b/drivers/net/wireless/ath/ath9k/main.c @@ -241,7 +241,7 @@ static bool ath_complete_reset(struct ath_softc *sc, bool start) if (sc->cur_chan->tsf_val) { u32 offset; - offset = ath9k_hw_get_tsf_offset(&sc->cur_chan->tsf_ts, + offset = ath9k_hw_get_tsf_offset(&sc->cur_chan->tsf_kt, NULL); ath9k_hw_settsf64(ah, sc->cur_chan->tsf_val + offset); } -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists