netdev - Re: [PATCH net] bridge: Don't include NDA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 31 Jul 2014 12:19:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	makita.toshiaki@....ntt.co.jp
Cc:	stephen@...workplumber.org, vyasevic@...hat.com,
	netdev@...r.kernel.org, bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net] bridge: Don't include NDA_VLAN for FDB entries
 with vid 0

From: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
Date: Wed, 30 Jul 2014 13:31:51 +0900

> An FDB entry with vlan_id 0 doesn't mean it is used in vlan 0, but used when
> vlan_filtering is disabled.
> 
> There is inconsistency around NDA_VLAN whose payload is 0 - even if we add
> an entry by RTM_NEWNEIGH without any NDA_VLAN, and even though adding an
> entry with NDA_VLAN 0 is prohibited, we get an entry with NDA_VLAN 0 by
> RTM_GETNEIGH.
> 
> Dumping an FDB entry with vlan_id 0 shouldn't include NDA_VLAN.
> 
> Signed-off-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>

This is clearly the right thing to do, since upon FDB addition we reject
NDA_VLAN attributes with value zero.

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html