netdev - Re: [PATCH v2] ipv6: addrconf: fix mcast route for GRE devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140731201926.GA754314@jupiter.n2.diac24.net>
Date:	Thu, 31 Jul 2014 22:19:26 +0200
From:	David Lamparter <equinox@...c24.net>
To:	Hannes Frederic Sowa <hannes@...essinduktion.org>
Cc:	David Miller <davem@...emloft.net>, equinox@...c24.net,
	netdev@...r.kernel.org, stephen@...workplumber.org
Subject: Re: [PATCH v2] ipv6: addrconf: fix mcast route for GRE devices

On Thu, Jul 31, 2014 at 09:37:34PM +0200, Hannes Frederic Sowa wrote:
> On Do, 2014-07-31 at 12:06 -0700, David Miller wrote:
> > From: David Lamparter <equinox@...c24.net>
> > Date: Wed, 30 Jul 2014 17:39:57 +0200
> > 
> > > GRE devices, for some reason, were coming up with an autoconfigured
> > > address, but no ff00::/8 route in the local table.  This breaks any kind
> > > of multicast, in particular OSPFv3, mDNS, - and ND.  In fact, IPv6 only
> > > works at all because there is little need for ND on PtP devices.
> > > 
> > > Adding any other IPv6 address on the device from userspace would rectify
> > > this issue through inet6_addr_add()/addrconf_add_dev() - and would leave
> > > the route around even if the address was later removed.  (This is
> > > probably why this issue was not discovered earlier.  AFAICS it has been
> > > there from the beginning, e.g. aee80b5 "generate link local address for
> > > GRE tunnel")
> > > 
> > > (Note: multicast is supported on GRE devices of all kinds, including PtP
> > > GRE, P-t-Mcast GRE and NBMA-GRE.)
> > > 
> > > Fixes: aee80b54b235 (ipv6: generate link local address for GRE tunnel)
> > > Signed-off-by: David Lamparter <equinox@...c24.net>
> > > Cc: Hannes Frederic Sowa <hannes@...essinduktion.org>
> > > Cc: Stephen Hemminger <stephen@...workplumber.org>
> > 
> > Hannes, are you OK with this version?  Please ACK if so.
> 
> The alternate version does provide the same semantic change and makes
> the code more readable. Both changes are technically correct, I acked
> the alternate version already.

Give me a few min, I'll go base the other one on this one, that way
there's one 2-line patch changing semantics (this one) and another
50-line patch just mechanically moving stuff around.

-David
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html