netdev - Re: [PATCH v2] net: fix the counter ICMP_MIB_INERRORS/ICMP6_MIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1406840726.13603.3.camel@localhost>
Date:	Thu, 31 Jul 2014 23:05:26 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Duan Jiong <duanj.fnst@...fujitsu.com>
Cc:	David Miller <davem@...emloft.net>, eric.dumazet@...il.com,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v2] net: fix the counter
 ICMP_MIB_INERRORS/ICMP6_MIB_INERRORS

On Do, 2014-07-31 at 17:54 +0800, Duan Jiong wrote:
> When dealing with ICMPv[46] Error Message, function icmp_socket_deliver()
> and icmpv6_notify() do some valid checks on packet's length, but then some
> protocols check packet's length redaudantly. So remove those duplicated
> statements, and increase counter ICMP_MIB_INERRORS/ICMP6_MIB_INERRORS in
> function icmp_socket_deliver() and icmpv6_notify() respectively.
> 
> In addition, add missed counter in udp6/udplite6 when socket is NULL.
> 
> Signed-off-by: Duan Jiong <duanj.fnst@...fujitsu.com>
> ---
> 
> v2: remove nested rcu_read_lock from icmpv6_notify

Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

IPv4 handler can also be cleaned up. ;)

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html