netdev - Re: [PATCH v3 net] tcp: Fix integer-overflow in TCP vegas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140730.173147.1009537751381441905.davem@davemloft.net>
Date:	Wed, 30 Jul 2014 17:31:47 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	christoph.paasch@...ouvain.be
Cc:	netdev@...r.kernel.org, stephen@...workplumber.org,
	ncardwell@...gle.com, eric.dumazet@...il.com,
	David.Laight@...LAB.COM, doug.leith@...m.ie
Subject: Re: [PATCH v3 net] tcp: Fix integer-overflow in TCP vegas

From: Christoph Paasch <christoph.paasch@...ouvain.be>
Date: Tue, 29 Jul 2014 13:40:57 +0200

> In vegas we do a multiplication of the cwnd and the rtt. This
> may overflow and thus their result is stored in a u64. However, we first
> need to cast the cwnd so that actually 64-bit arithmetic is done.
> 
> Then, we need to do do_div to allow this to be used on 32-bit arches.
> 
> Cc: Stephen Hemminger <stephen@...workplumber.org>
> Cc: Neal Cardwell <ncardwell@...gle.com>
> Cc: Eric Dumazet <eric.dumazet@...il.com>
> Cc: David Laight <David.Laight@...LAB.COM>
> Cc: Doug Leith <doug.leith@...m.ie>
> Fixes: 8d3a564da34e (tcp: tcp_vegas cong avoid fix)
> Signed-off-by: Christoph Paasch <christoph.paasch@...ouvain.be>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html