netdev - Re: [PATCH net-next 1/2] net: Header length compution function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53DA61FE.40406@intel.com>
Date:	Thu, 31 Jul 2014 08:34:22 -0700
From:	Alexander Duyck <alexander.h.duyck@...el.com>
To:	David Miller <davem@...emloft.net>
CC:	eric.dumazet@...il.com, amirv@...lanox.com, netdev@...r.kernel.org,
	ogerlitz@...lanox.com, yevgenyp@...lanox.com, idos@...lanox.com
Subject: Re: [PATCH net-next 1/2] net: Header length compution function

On 07/30/2014 06:39 PM, David Miller wrote:
> From: Alexander Duyck <alexander.h.duyck@...el.com>
> Date: Wed, 30 Jul 2014 07:26:33 -0700
> 
>> It wasn't that I don't trust the core function.  We already had some of
>> our own code floating around for the out-of-tree LRO and so I simply
>> made use of that as it allowed for code reuse in our driver.
> 
> It would be nice if this code were converted to use the generic
> infrastructure, at some point at least.

I agree.  That is one of the reasons why I supported an earlier approach
that had made a function that was shared between the drivers.  My only
real concern was the on-stack skb approach.

The only other change I see that I might need to address would be to add
FCoE support to the function and then I can probably switch over ixgbe
to use it.

> 
> I don't think my proposed patch is a bad trade off.  Where we have the
> __skb_header_pointer() thing that takes preloaded pointers and header
> length values.  It adds only one test which frankly should never
> trigger and can be moved down into skb_copy_bits() or similar.
> 

This works for me.  Once it is in I can see about pushing a patch to add
some FCoE support and work on moving over igb and ixgbe.

Thanks,

Alex
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html