netdev - Re: [PATCH net-next v3] net: stmmac: add platform init/exit for Altera's ARM socfpga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGb2v65yyfuJvZhYKTvROOZmumPAyLNfSGSPHeJEhSKnM9ELrA@mail.gmail.com>
Date:	Sat, 2 Aug 2014 00:06:22 +0800
From:	Chen-Yu Tsai <wens@...e.org>
To:	Vince Bridgers <vbridgers2013@...il.com>
Cc:	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Giuseppe Cavallaro <peppe.cavallaro@...com>,
	vbridger@...era.com
Subject: Re: [PATCH net-next v3] net: stmmac: add platform init/exit for
 Altera's ARM socfpga

Hi,

On Tue, Jul 29, 2014 at 3:07 AM, Vince Bridgers <vbridgers2013@...il.com> wrote:
> This patch adds platform init/exit functions and modifications to support
> suspend/resume for the Altera Cyclone 5 SOC Ethernet controller. The platform
> exit function puts the controller into reset using the socfpga reset
> controller driver. The platform init function sets up the Synopsys mac by
> first making sure the Ethernet controller is held in reset, programming the
> phy mode through external support logic, then deasserts reset through
> the socfpga reset manager driver.

Sorry for the very late reply after the fact.

Is it possible to assert/deassert the reset in the driver core
suspend/resume functions, before the clock is enabled?

Since the platform hooks are called before the core resume, and after
core suspend, doing it in the core has the same order as you have in your
platform code. And the driver core already supports reset controls,
deasserting them at probe time, and asserting them when removed.

At the same time, phy_suspend/phy_resume could be moved into the driver
core as well.

After that, you only need to keep is socfpga_dwmac_init() calling
socfpga_dwmac_setup().

I did not attempt this when I added the platform code hooks, as I did not
have suspend capable hardware to test it on.

> Signed-off-by: Vince Bridgers <vbridgers2013@...il.com>
> ---
> V3: respin for net-next after phy_suspend was exported by libphy
>     per suggestion from Florian. No changes to patch from V2 -> V3.
> V2: Address review comments - add line break before structure decl
> ---
>  .../net/ethernet/stmicro/stmmac/dwmac-socfpga.c    |   69 ++++++++++++++++++++
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c  |    4 ++
>  2 files changed, 73 insertions(+)
>
[...]

Cheers
ChenYu
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html