netdev - Re: [PATCH net-next 3/3] nftables: Convert nft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <970429e5-2465-40f2-998b-b82dab3debe8@email.android.com>
Date:	Fri, 01 Aug 2014 11:17:03 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Thomas Graf <tgraf@...g.ch>, davem@...emloft.net,
	netdev@...r.kernel.org
CC:	linux-kernel@...r.kernel.org, paulmck@...ux.vnet.ibm.com,
	josh@...htriplett.org, challa@...ronetworks.com,
	walpole@...pdx.edu, dev@...nvswitch.org, tklauser@...tanz.ch,
	netfilter-devel@...r.kernel.org
Subject: Re: [PATCH net-next 3/3] nftables: Convert nft_hash to use generic rhashtable

On 1. August 2014 09:52:00 GMT+01:00, Thomas Graf <tgraf@...g.ch> wrote:
>If the set size is known in advance, the table is sized accordingly,
>otherwise the table size will default to 64. This is a slight change
>in behaviour as previously the default was 4 which eventually required
>many expansion iterations.

That's assuming a sufficient number of entries will be added. I think there
will be many cases in nftables where the number will be lower. Since
expansion is not very expansive this number was chosen very deliberately
and I'd prefer to keep it.

Other than that:

Acked-by: Patrick McHardy <kaber@...sh.net>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html