lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20140731.183109.742589264674095169.davem@davemloft.net>
Date:	Thu, 31 Jul 2014 18:31:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	akeem.g.abodunrin@...el.com
Cc:	aaron.f.brown@...el.com, netdev@...r.kernel.org, gospo@...hat.com,
	sassmann@...hat.com
Subject: Re: [net-next 06/15] i40e: Move some variable declarations out of
 a loop

From: "Abodunrin, Akeem G" <akeem.g.abodunrin@...el.com>
Date: Thu, 31 Jul 2014 23:56:19 +0000

> This is done because other codes have to use it before the loop...
> 
> Hope you understand the reason for this - and that is how it supposed to be originally, we have to increase the scope of the variables so that other code that are not in the loop can use it.

What codes?  I looked at the patches after this one and none of them use
the variables.

If anything you should make this change in the patch that needs it, not
beforehand.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ