netdev - Re: [PATCH net-next 0/3] Make is_kdump_kernel() accessible from modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140801124416.GB1316@redhat.com>
Date:	Fri, 1 Aug 2014 08:44:16 -0400
From:	Vivek Goyal <vgoyal@...hat.com>
To:	David Miller <davem@...emloft.net>
Cc:	amirv@...lanox.com, andi@...stfloor.org, akpm@...ux-foundation.org,
	netdev@...r.kernel.org, ogerlitz@...lanox.com,
	yevgenyp@...lanox.com
Subject: Re: [PATCH net-next 0/3] Make is_kdump_kernel() accessible from
 modules

On Thu, Jul 31, 2014 at 12:22:44PM -0700, David Miller wrote:
> From: Vivek Goyal <vgoyal@...hat.com>
> Date: Thu, 31 Jul 2014 09:07:56 -0400
> 
> > If there are performance implications of low memory profile, then user
> > needs to live with it. Otherwise they should not use low_memory_env
> > boot option to begin with.
> 
> I personally think we should avoid changing scripts, by having a kdump
> kernel force this low_mem profile to be true.

If we go with current implementation, we don't have to change any of the
existing scripts.  Current implementation enforces low mem profile in
drivers for kdump kernel.

I am growing more skeptical of suggested low_mem_env boot option as there
will be contention that for different amount of low memory there should
be different profiles. One might argue that for 256MB use one kind of
profile while same profile might not be best fit for 2G of memory.

So instead of venturing into too generic option, I am fine with sticking
to a more custom option which works for kdump use case (is_kdump_kernel()).

So I would like to ack this patch series in current form.

Acked-by: Vivek Goyal <vgoyal@...hat.com>

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html