lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 01 Aug 2014 15:12:28 +0100 From: Patrick McHardy <kaber@...sh.net> To: Thomas Graf <tgraf@...g.ch>, Nikolay Aleksandrov <nikolay@...hat.com> CC: davem@...emloft.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, paulmck@...ux.vnet.ibm.com, josh@...htriplett.org, challa@...ronetworks.com, walpole@...pdx.edu, dev@...nvswitch.org, tklauser@...tanz.ch, netfilter-devel@...r.kernel.org Subject: Re: [PATCH net-next 3/3] nftables: Convert nft_hash to use generic rhashtable On 1. August 2014 14:49:01 GMT+01:00, Thomas Graf <tgraf@...g.ch> wrote: >On 08/01/14 at 02:21pm, Nikolay Aleksandrov wrote: >> Sorry for the late response but I just got around to check the 3rd >patch now, >> so my question about this fragment is: before nft_hash_remove() would >free the >> element after removal, but after this change I don't see where and >when the >> removed element would get freed ? > >You are right. Looking at this closer we were leaking references even >before the change because it would not call nft_data_uninit() to >release >the data objects. So it should really just call >nft_hash_elem_destroy(). No, the data uninit is performed by the set core. Just freeing it is fine. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists