netdev - Re: [PATCH] iovec: make sure the caller actually wants anything in memcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140802.152623.2217732437810296124.davem@davemloft.net>
Date:	Sat, 02 Aug 2014 15:26:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sasha.levin@...cle.com
Cc:	jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iovec: make sure the caller actually wants anything in
 memcpy_fromiovecend

From: Sasha Levin <sasha.levin@...cle.com>
Date: Thu, 31 Jul 2014 23:00:35 -0400

> Check for cases when the caller requests 0 bytes instead of running off
> and dereferencing potentially invalid iovecs.
> 
> Signed-off-by: Sasha Levin <sasha.levin@...cle.com>

Applied, thanks.

BTW, if you look at the function above this one (memcpy_toiovecend) it avoids
this issue by encompassing all of the logic in a top-level loop which terminates
when len <= 0.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html