lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 04 Aug 2014 09:05:55 +0900 From: YOSHIFUJI Hideaki <hideaki.yoshifuji@...aclelinux.com> To: Dmitry Popov <ixaphire@...tor.net>, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, David Miller <davem@...emloft.net> CC: hideaki.yoshifuji@...aclelinux.com Subject: Re: [PATCH] tcp: md5: remove unneeded check in tcp_v4_parse_md5_keys Dmitry Popov wrote: > tcpm_key is an array inside struct tcp_md5sig, there is no need to check it > against NULL. > > Signed-off-by: Dmitry Popov <ixaphire@...tor.net> Acked-by: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org> (IPv6 side is okay.) > --- > net/ipv4/tcp_ipv4.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c > index 77cccda..8ea4eff 100644 > --- a/net/ipv4/tcp_ipv4.c > +++ b/net/ipv4/tcp_ipv4.c > @@ -1064,7 +1064,7 @@ static int tcp_v4_parse_md5_keys(struct sock *sk, char __user *optval, > if (sin->sin_family != AF_INET) > return -EINVAL; > > - if (!cmd.tcpm_key || !cmd.tcpm_keylen) > + if (!cmd.tcpm_keylen) > return tcp_md5_do_del(sk, (union tcp_md5_addr *)&sin->sin_addr.s_addr, > AF_INET); > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > --yoshfuji -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists