netdev - Re: [PATCH 02/19] drivers: atm: fix %d confusingly prefixed with 0x in format strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Aug 2014 07:16:38 -0400
From:	chas williams - CONTRACTOR <chas@....nrl.navy.mil>
To:	Hans Wennborg <hans@...shq.net>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/19] drivers: atm: fix %d confusingly prefixed with 0x
 in format strings

Acked-by: Chas Williams <chas@....nrl.navy.mil>

On Sun,  3 Aug 2014 17:18:20 -0700
Hans Wennborg <hans@...shq.net> wrote:

> Signed-off-by: Hans Wennborg <hans@...shq.net>
> ---
>  drivers/atm/eni.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c
> index b1955ba..d65975a 100644
> --- a/drivers/atm/eni.c
> +++ b/drivers/atm/eni.c
> @@ -2155,7 +2155,7 @@ static int eni_proc_read(struct atm_dev *dev,loff_t *pos,char *page)
>  
>  		if (!tx->send) continue;
>  		if (!--left) {
> -			return sprintf(page,"tx[%d]:    0x%ld-0x%ld "
> +			return sprintf(page, "tx[%d]:    0x%lx-0x%lx "
>  			    "(%6ld bytes), rsv %d cps, shp %d cps%s\n",i,
>  			    (unsigned long) (tx->send - eni_dev->ram),
>  			    tx->send-eni_dev->ram+tx->words*4-1,tx->words*4,
> @@ -2181,7 +2181,7 @@ static int eni_proc_read(struct atm_dev *dev,loff_t *pos,char *page)
>  			if (--left) continue;
>  			length = sprintf(page,"vcc %4d: ",vcc->vci);
>  			if (eni_vcc->rx) {
> -				length += sprintf(page+length,"0x%ld-0x%ld "
> +				length += sprintf(page+length, "0x%lx-0x%lx "
>  				    "(%6ld bytes)",
>  				    (unsigned long) (eni_vcc->recv - eni_dev->ram),
>  				    eni_vcc->recv-eni_dev->ram+eni_vcc->words*4-1,

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html