netdev - Re: [PATCH] r8152: correct error returns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140804.151827.179999106523102125.davem@davemloft.net>
Date:	Mon, 04 Aug 2014 15:18:27 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	oneukum@...e.de
Cc:	netdev@...r.kernel.org, nic_swsd@...ltek.com
Subject: Re: [PATCH] r8152: correct error returns

From: Oliver Neukum <oneukum@...e.de>
Date: Sun, 03 Aug 2014 09:06:58 +0200

> OK, I just looked at this single driver. I'll try to come up with
> a generic solution. The mapping is a bit simplistic. I should let
> -ENOMEM pass for example.

And the problem also isn't limited USB networking drivers, just
about every driver I looked at passed these autopm errors right
back to userspace.

Largely people just call the autopm interfaces and propagate any
errors they get.  So you probably want to put the translator/filter
there.

But of course, that doesn't handle the non-autopm code paths into the
PM layer that can end up in this situation.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html