netdev - Re: linux-next: net/netlink/diag.c:106 suspicious rcu_dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHA+R7OB_gTYPKtqw-iry+nfkTbmApw4GPpeKjqfXugcit4Guw@mail.gmail.com>
Date:	Wed, 6 Aug 2014 14:20:59 -0700
From:	Cong Wang <cwang@...pensource.com>
To:	Thomas Graf <tgraf@...g.ch>
Cc:	Andrey Wagin <avagin@...il.com>, netdev <netdev@...r.kernel.org>
Subject: Re: linux-next: net/netlink/diag.c:106 suspicious rcu_dereference_protected()
 usage!

On Wed, Aug 6, 2014 at 12:51 PM, Thomas Graf <tgraf@...g.ch> wrote:
> On 08/06/14 at 10:52am, Cong Wang wrote:
>>
>> Looks like we should hold rcu_read_lock() before calling __netlink_diag_dump().
>
> netlink_diag_dump() still acquires nl_table_lock which is pointless as
> a separate mutex has been introduced to protect mutations. I will send
> a patch to RCU'ify it properly.

Agreed, but that's likely a net-next material.

I think we need the following quick fix for net.

View attachment "netlink-diag.diff" of type "text/plain" (1268 bytes)