netdev - Re: [PATCH] net: reallocate new socket option number for IPV6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140806221313.GA4426@breakpoint.cc>
Date:	Thu, 7 Aug 2014 00:13:13 +0200
From:	Florian Westphal <fw@...len.de>
To:	Pablo Neira Ayuso <pablo@...filter.org>
Cc:	therbert@...gle.com, netfilter-devel@...r.kernel.org,
	davem@...emloft.net, davej@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: reallocate new socket option number for
 IPV6_AUTOFLOWLABEL

Pablo Neira Ayuso <pablo@...filter.org> wrote:
> cb1ce2e ("ipv6: Implement automatic flow label generation on transmit")
> accidentally uses socket option 64, which is already used by ip6tables:
> 
>  IP6T_SO_SET_REPLACE / IP6T_SO_GET_INFO               64
>  IP6T_SO_SET_ADD_COUNTERS / IP6T_SO_GET_ENTRIES       65
> 
> There is comment include/uapi/linux/in6.h warning about that.
> 
> Cc: Tom Herbert <therbert@...gle.com>
> Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>
> ---
>  include/uapi/linux/in6.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/in6.h b/include/uapi/linux/in6.h
> index 22b7a69..1d929c0 100644
> --- a/include/uapi/linux/in6.h
> +++ b/include/uapi/linux/in6.h
> @@ -233,7 +233,6 @@ struct in6_flowlabel_req {
>  #if 0	/* not yet */
>  #define IPV6_USE_MIN_MTU	63
>  #endif
> -#define IPV6_AUTOFLOWLABEL	64
>  
>  /*
>   * Netfilter (1)
> @@ -250,6 +249,7 @@ struct in6_flowlabel_req {
>   */
>  #define IPV6_RECVTCLASS		66
>  #define IPV6_TCLASS		67
> +#define IPV6_AUTOFLOWLABEL	68

This clashes with IP6T_SO_GET_REVISION_MATCH 8-}
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html