netdev - Re: [PATCH v2] net: reallocate new socket option number for IPV6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140806.152536.832906295015490098.davem@davemloft.net>
Date:	Wed, 06 Aug 2014 15:25:36 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	pablo@...filter.org
Cc:	therbert@...gle.com, netfilter-devel@...r.kernel.org,
	davej@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: reallocate new socket option number for
 IPV6_AUTOFLOWLABEL

From: Pablo Neira Ayuso <pablo@...filter.org>
Date: Thu,  7 Aug 2014 00:17:09 +0200

> cb1ce2e ("ipv6: Implement automatic flow label generation on transmit")
> accidentally uses socket option 64, which is already used by ip6tables:
> 
>  IP6T_SO_SET_REPLACE / IP6T_SO_GET_INFO               64
>  IP6T_SO_SET_ADD_COUNTERS / IP6T_SO_GET_ENTRIES       65
> 
> There is comment include/uapi/linux/in6.h warning about that.
> 
> Allocate 70 for this, which seems to be unused instead.
> 
> Cc: Tom Herbert <therbert@...gle.com>
> Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>

Applied, thanks Pablo.

The way we maintain this number space seems very error prone, FWIW.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html