netdev - Re: [PATCH net-next v2] tcp: md5: check md5 signature without socket lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140807023347.ad7215e4c192672ef23ee3ac@qrator.net>
Date:	Thu, 7 Aug 2014 02:33:47 +0400
From:	Dmitry Popov <ixaphire@...tor.net>
To:	David Miller <davem@...emloft.net>
Cc:	yoshfuji@...ux-ipv6.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] tcp: md5: check md5 signature without
 socket lock

On Wed, 06 Aug 2014 14:52:18 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:

> From: Dmitry Popov <ixaphire@...tor.net>
> Date: Thu, 7 Aug 2014 01:49:53 +0400
> 
> > Since a8afca032 (tcp: md5: protects md5sig_info with RCU) tcp_md5_do_lookup
> > doesn't require socket lock, rcu_read_lock is enough. Therefore socket lock is
> > no longer required for tcp_v{4,6}_inbound_md5_hash too, so we can move these
> > calls (wrapped with rcu_read_{,un}lock) before bh_lock_sock:
> > from tcp_v{4,6}_do_rcv to tcp_v{4,6}_rcv.
> > 
> > Signed-off-by: Dmitry Popov <ixaphire@...tor.net>
> 
> Please respin this against the current 'net' tree, it doesn't apply.

Oops, my bad, sorry. I will resubmit.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html