netdev - Re: [PATCH net-next v4 5/6] net-timestamp: TCP timestamping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+FuTSdqxXOod_V6+cfYdLgFZ1mabi1O34UT92XEpqGiFtfz1g@mail.gmail.com>
Date:	Wed, 6 Aug 2014 09:08:16 -0400
From:	Willem de Bruijn <willemb@...gle.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Network Development <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH net-next v4 5/6] net-timestamp: TCP timestamping

On Wed, Aug 6, 2014 at 2:55 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Mon, 2014-08-04 at 22:11 -0400, Willem de Bruijn wrote:
>> TCP timestamping extends SO_TIMESTAMPING to bytestreams.
>
>>
>> +void tcp_tx_timestamp(struct sock *sk, struct sk_buff *skb)
>> +{
>> +     struct skb_shared_info *shinfo = skb_shinfo(skb);
>> +
>> +     sock_tx_timestamp(sk, &shinfo->tx_flags);
>
> Arg, this breaks SKBTX_SHARED_FRAG support.
>
> And sock_tx_timestamp() is quite expensive for TCP where only
> SKBTX_ACK_TSTAMP could possibly be supported ?

The other options can also be set. But it is expensive. It can
actually be wrapped into a branch if (sk->sk_tsflags), to avoid
calling the function in the common case.

>
> static void tcp_tx_timestamp(const struct sock *sk, struct sk_buff *skb)
>
> I'll send a cumulative patch.

Thanks for spotting and fixing the critical shared frags issue. I
can send a patch for this, the two static functions identified by
sparse and the sequence number arithmetic in tcp_gso_tstamp.
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html