netdev - Re: [PATCH 3.4-stable v2] ipv6: reallocate addrconf router for ipv6 address when lo device up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140806140509.GB12150@hercules>
Date:	Wed, 6 Aug 2014 15:05:09 +0100
From:	Luis Henriques <luis.henriques@...onical.com>
To:	chenweilong <chenweilong@...wei.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	stable@...r.kernel.org, Sabrina Dubroca <sd@...asysnail.net>,
	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	Gao feng <gaofeng@...fujitsu.com>,
	Li Zefan <lizefan@...wei.com>
Subject: Re: [PATCH 3.4-stable v2] ipv6: reallocate addrconf router for ipv6
 address when lo device up

On Wed, Aug 06, 2014 at 04:18:17PM +0800, chenweilong wrote:
> It fix the bug 67951 on bugzilla
> https://bugzilla.kernel.org/show_bug.cgi?id=67951
> 
> The patch can't be applied directly, as it' used the function introduced
> by "commit 94e187c0" ip6_rt_put(), that patch can't be applied directly
> either.
>

I'm queuing this commit for the 3.11 kernel as well.  Thanks!

Cheers,
--
Luís

> ====================
> 
> From: Gao feng <gaofeng@...fujitsu.com>
> 
> commit 33d99113b1102c2d2f8603b9ba72d89d915c13f5 upstream.
> 
> This commit don't have a stable tag, but it fix the bug
> no reply after loopback down-up.It's very worthy to be
> applied to stable 3.4 kernels.
> 
> The bug is 67951 on bugzilla
> https://bugzilla.kernel.org/show_bug.cgi?id=67951
> 
> 
> CC: Sabrina Dubroca <sd@...asysnail.net>
> CC: Hannes Frederic Sowa <hannes@...essinduktion.org>
> Reported-by: Weilong Chen <chenweilong@...wei.com>
> Signed-off-by: Weilong Chen <chenweilong@...wei.com>
> Signed-off-by: Gao feng <gaofeng@...fujitsu.com>
> Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
> Signed-off-by: David S. Miller <davem@...emloft.net>
> [weilong: s/ip6_rt_put/dst_release]
> Signed-off-by: Chen Weilong <chenweilong@...wei.com>
> ---
>  net/ipv6/addrconf.c | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index abfa007..25399bf 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -2435,8 +2435,18 @@ static void init_loopback(struct net_device *dev)
>  			if (sp_ifa->flags & (IFA_F_DADFAILED | IFA_F_TENTATIVE))
>  				continue;
> 
> -			if (sp_ifa->rt)
> -				continue;
> +			if (sp_ifa->rt) {
> +				/* This dst has been added to garbage list when
> +				 * lo device down, release this obsolete dst and
> +				 * reallocate a new router for ifa.
> +				 */
> +				if (sp_ifa->rt->dst.obsolete > 0) {
> +					dst_release(&sp_ifa->rt->dst);
> +					sp_ifa->rt = NULL;
> +				} else {
> +					continue;
> +				}
> +			}
> 
>  			sp_rt = addrconf_dst_alloc(idev, &sp_ifa->addr, 0);
> 
> -- 1.7.12
> 
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html