netdev - Re: [PATCH net] netlink: hold nl_sock_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140806.191824.1719351238922873517.davem@davemloft.net>
Date:	Wed, 06 Aug 2014 19:18:24 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	tgraf@...g.ch
Cc:	cwang@...pensource.com, avagin@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] netlink: hold nl_sock_hash_lock during diag dump

From: Thomas Graf <tgraf@...g.ch>
Date: Thu, 7 Aug 2014 00:18:47 +0100

> [PATCH net] netlink: hold nl_sock_hash_lock during diag dump
> 
> Although RCU protection would be possible during diag dump, doing
> so allows for concurrent table mutations which can render the
> in-table offset between individual Netlink messages invalid and
> thus cause legitimate sockets to be skipped in the dump.
> 
> Since the diag dump is relatively low volume and consistency is
> more important than performance, the table mutex is held during
> dump.
> 
> Reported-by: Andrey Wagin <avagin@...il.com>
> Signed-off-by: Thomas Graf <tgraf@...g.ch>
> Fixes: e341694e3eb57fc ("netlink: Convert netlink_lookup() to use RCU protected hash table")

Applied, thanks Thomas.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html