netdev - Re: [PATCH] asix - Add support for LyconSys FiberGecko

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 07 Aug 2014 20:33:53 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	David Hollis <dhollis@...ehollis.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] asix - Add support for LyconSys FiberGecko

Hello.

On 08/07/2014 07:53 PM, David Hollis wrote:

> Reported-by: Sven Kreiensen <s.kreiensen@...onsys.com>
> Signed-off-by: David Hollis <dhollis@...ehollis.com>

> ---
>   drivers/net/usb/asix_devices.c | 25 ++++++++++++++++++++++++-
>   1 file changed, 24 insertions(+), 1 deletion(-)

> diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
> index 5d19409..d09f2ea 100644
> --- a/drivers/net/usb/asix_devices.c
> +++ b/drivers/net/usb/asix_devices.c
[...]
> @@ -648,6 +648,12 @@ static int ax88178_reset(struct usbnet *dev)
>   	asix_sw_reset(dev, 0);
>   	msleep(150);
>
> +	/* LyconSys FiberGecko: Turn on PHY */
> +	if (dev->driver_info->flags == 0x20061201) {

    Hm, don't use magic values please. Doesn't the flags get assigned a 
combination  of FLAG_* values below? Or you mixed up 'flags' and 'data' fields?

> +		/* Power on Phy: set gpio2=high */
> +		asix_write_gpio(dev, AX_GPIO_GPO2EN | AX_GPIO_GPO_2, 50);
> +	}
> +
>   	asix_sw_reset(dev, AX_SWRESET_PRL | AX_SWRESET_IPPD);
>   	msleep(150);
>
> @@ -946,6 +952,19 @@ static const struct driver_info hg20f9_info = {
>   	.data = FLAG_EEPROM_MAC,
>   };
>
> +static const struct driver_info lyconsys_fibergecko100_info = {
> +	.description = "LyconSys FiberGecko 100 USB 2.0 to Ethernet Adapter",
> +	.bind = ax88178_bind,
> +	.status = asix_status,
> +	.link_reset = ax88178_link_reset,
> +	.reset = ax88178_link_reset,
> +	.flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_LINK_INTR |
> +		 FLAG_MULTI_PACKET,
> +	.rx_fixup =	asix_rx_fixup_common,
> +	.tx_fixup =	asix_tx_fixup,

    Hm, why this sudden change of the initializer style?

> +	.data = 0x20061201,
> +};
> +

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html