netdev - Re: [PATCH] 6lowpan: Allow 6LoWPAN to be modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <144B79BA-C835-4EF4-8FF5-533D535A5143@holtmann.org>
Date:	Thu, 7 Aug 2014 11:31:11 -0700
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Alexander Aring <alex.aring@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	linux-zigbee-devel@...ts.sourceforge.net,
	BlueZ development <linux-bluetooth@...r.kernel.org>,
	linux-wpan@...r.kernel.org,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] 6lowpan: Allow 6LoWPAN to be modular

Hi Geert,

>>> Change config symbol 6LOWPAN from type bool to type tristate, so
>>> 6LoWPAN can be built modular, just like IPV6
>>> 
>>> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>>> ---
>>> net/6lowpan/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/net/6lowpan/Kconfig b/net/6lowpan/Kconfig
>>> index 028a5c6d1f61..e4a02ef55102 100644
>>> --- a/net/6lowpan/Kconfig
>>> +++ b/net/6lowpan/Kconfig
>>> @@ -1,5 +1,5 @@
>>> config 6LOWPAN
>>> -     bool "6LoWPAN Support"
>>> +     tristate "6LoWPAN Support"
>> 
>> is this a regression from the previous CONFIG_6LOWPAN separation that we introduced? If it is, then it might be easiest if Dave just takes it into his net tree. Otherwise I take it through bluetooth-next.
> 
> I hadn't thought about that... Checking...
> 
> Yes, I believe this is a regression.
> 
> In v3.16, my allmodconfig build had:
> 
> CONFIG_IEEE802154_6LOWPAN=m
> CONFIG_6LOWPAN_IPHC=m
> CONFIG_BT_6LOWPAN=y
> 
> Without my patch it has:
> 
> CONFIG_6LOWPAN=y
> CONFIG_IEEE802154_6LOWPAN=m
> CONFIG_BT_6LOWPAN=m
> 
> and iphc is what's in net/6lowpan/built-in.o now.

Acked-by: Marcel Holtmann <marcel@...tmann.org>

Dave, I am fine if you just queue this up for 3.17-rc1.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html