netdev - Re: sel_netif_init: 'err' is used uninitialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 07 Aug 2014 21:01:19 -0400
From:	Paul Moore <paul@...l-moore.com>
To:	David Miller <davem@...emloft.net>
Cc:	geert@...ux-m68k.org, linux-security-module@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: sel_netif_init: 'err' is used uninitialized

On Thursday, August 07, 2014 12:04:54 PM David Miller wrote:
> From: Paul Moore <paul@...l-moore.com>
> Date: Thu, 07 Aug 2014 10:26:14 -0400
> 
> > On Thursday, August 07, 2014 12:31:15 PM Geert Uytterhoeven wrote:
> > 
> >> 
> >> security/selinux/netif.c: In function ‘sel_netif_init’:
> >> /scratch/geert/linux/linux-m68k/security/selinux/netif.c:285: warning:
> >> ‘err’ is used uninitialized in this function
> >> 
> >> Should it just return 0, like before?
> >> Or should it return the return value of register_netdevice_notifier()
> >> instead, which also returns an error code? Or is that failure
> >> non-critical?
> > 
> > Hi,
> > 
> > I posted a fix for this two days ago to the SELinux list (see below).  As
> > soon as -rc1 is released and linux-next is back in business I'll be
> > pushing the patch to the SELinux #next branch.
> > 
> >  * http://marc.info/?l=selinux&m=140727033030054&w=2
> 
> With respect to this and the lack-of-inline warning fix we spoke about
> yesterday, why are you waiting and only pushing such bug fixes into your
> "next" branch?

Simply put, I didn't think the patches were significant enough to push at this 
point in time.
 
> Those sort of things should be sent to Linus now to correct the errors
> introduced during the merge window, as I have done last night for all
> of the networking merge fallout.

I'll (re)post the patches with a pull request in just a moment, CC'ing all the 
various mailing lists and you guys can figure out who best to merge them.

-- 
paul moore
www.paul-moore.com

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html