lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 8 Aug 2014 12:45:11 +0200 From: Michal Simek <michal.simek@...inx.com> To: Julia Lawall <Julia.Lawall@...6.fr>, Michal Simek <michal.simek@...inx.com> CC: <kernel-janitors@...r.kernel.org>, <netdev@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>, Uwe Kleine-König <u.kleine-koenig@...gutronix.de> Subject: Re: [PATCH 12/14] ll_temac: delete unneeded test before of_node_put On 08/08/2014 12:07 PM, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall@...6.fr> > > Of_node_put supports NULL as its argument, so the initial test is not > necessary. > > Suggested by Uwe Kleine-König. > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression e; > @@ > > -if (e) > of_node_put(e); > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr> > > --- > drivers/net/ethernet/xilinx/ll_temac_main.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c > index 8a6e5c2..36f4459 100644 > --- a/drivers/net/ethernet/xilinx/ll_temac_main.c > +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c > @@ -1148,8 +1148,7 @@ static int temac_of_remove(struct platform_device *op) > temac_mdio_teardown(lp); > unregister_netdev(ndev); > sysfs_remove_group(&lp->dev->kobj, &temac_attr_group); > - if (lp->phy_node) > - of_node_put(lp->phy_node); > + of_node_put(lp->phy_node); > lp->phy_node = NULL; > iounmap(lp->regs); > if (lp->sdma_regs) Reviewed-by: Michal Simek <michal.simek@...inx.com> Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists