lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 10 Aug 2014 10:46:46 -0700 From: Guenter Roeck <linux@...ck-us.net> To: Li Yang <leoli@...escale.com> CC: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org, Uwe Kleine-König <u.kleine-koenig@...gutronix.de> Subject: Re: [PATCH] net: ugg_geth: Fix build error in -next Grumble. Headline should be s/ugg/ucc, obviously. Guenter On 08/10/2014 09:19 AM, Guenter Roeck wrote: > powerpc:mpc83xx_defconfig and other builds fail with > > drivers/net/ethernet/freescale/ucc_geth.c: In function 'ucc_geth_remove': > drivers/net/ethernet/freescale/ucc_geth.c:3927:19: error: > 'struct ucc_geth_private' has no member named 'info' > of_node_put(ugeth->info->tbi_node); > ^ > drivers/net/ethernet/freescale/ucc_geth.c:3928:19: error: > 'struct ucc_geth_private' has no member named 'info' > of_node_put(ugeth->info->phy_node); > ^ > > Introduced by commit "net: ucc_geth: drop acquired references in probe error > path and remove". > >>>From the context, it appears that the variable is named ug_info. > > Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> > Signed-off-by: Guenter Roeck <linux@...ck-us.net> > --- > Only seen in -next. > > drivers/net/ethernet/freescale/ucc_geth.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c > index d6b64e3..3cf0478 100644 > --- a/drivers/net/ethernet/freescale/ucc_geth.c > +++ b/drivers/net/ethernet/freescale/ucc_geth.c > @@ -3924,8 +3924,8 @@ static int ucc_geth_remove(struct platform_device* ofdev) > unregister_netdev(dev); > free_netdev(dev); > ucc_geth_memclean(ugeth); > - of_node_put(ugeth->info->tbi_node); > - of_node_put(ugeth->info->phy_node); > + of_node_put(ugeth->ug_info->tbi_node); > + of_node_put(ugeth->ug_info->phy_node); > > return 0; > } > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists