lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 10 Aug 2014 11:42:41 -0700 From: Guenter Roeck <linux@...ck-us.net> To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> CC: Li Yang <leoli@...escale.com>, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net: ugg_geth: Fix build error in -next On 08/10/2014 11:36 AM, Uwe Kleine-König wrote: > Hello Guenter, > > On Sun, Aug 10, 2014 at 09:19:14AM -0700, Guenter Roeck wrote: >> powerpc:mpc83xx_defconfig and other builds fail with >> >> drivers/net/ethernet/freescale/ucc_geth.c: In function 'ucc_geth_remove': >> drivers/net/ethernet/freescale/ucc_geth.c:3927:19: error: >> 'struct ucc_geth_private' has no member named 'info' >> of_node_put(ugeth->info->tbi_node); >> ^ >> drivers/net/ethernet/freescale/ucc_geth.c:3928:19: error: >> 'struct ucc_geth_private' has no member named 'info' >> of_node_put(ugeth->info->phy_node); >> ^ >> >> Introduced by commit "net: ucc_geth: drop acquired references in probe error >> path and remove". >> >> From the context, it appears that the variable is named ug_info. >> >> Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> >> Signed-off-by: Guenter Roeck <linux@...ck-us.net> >> --- >> Only seen in -next. > My patch was only sent just now, but it has the subject right: > Excellent. > http://mid.gmane.org/1407695525-32227-1-git-send-email-u.kleine-koenig@pengutronix.de > The link doesn't seem to work for some reason. > Another upside is that it contains a Fixes: header. > Even better. I need to start using that. > Other than that my patch is the same. In case davem picks up yours: > > Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> > I don't need the glory ;-). Dave, please pick Uwe's patch. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists