lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 Aug 2014 15:39:18 +0100 From: Wei Liu <wei.liu2@...rix.com> To: David Vrabel <david.vrabel@...rix.com> CC: Wei Liu <wei.liu2@...rix.com>, <netdev@...r.kernel.org>, <xen-devel@...ts.xen.org>, Ian Campbell <ian.campbell@...rix.com>, Zoltan Kiss <zoltan.kiss@...rix.com> Subject: Re: [Xen-devel] [PATCH net v2 2/3] xen-netback: don't stop dealloc kthread too early On Mon, Aug 11, 2014 at 03:34:48PM +0100, David Vrabel wrote: [...] > >> > >> And cleaning it up a bit (the while() could be a for(;;)). > >> > > > > Unfortunately this approach is bogus. If xenbus thread is not blocked it > > can free up various resources while dealloc thread is running -- queue > > can be gone under dealloc thread's feet. > > kthread_stop() waits until the thread exits (like pthread_join()). > > /** > * kthread_stop - stop a thread created by kthread_create(). > * @k: thread created by kthread_create(). > * > * Sets kthread_should_stop() for @k to return true, wakes it, and > * waits for it to exit. > Ah, misremeber the behaviour of kthread_stop. Sorry for the noise. Wei. > David -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists