netdev - Re: [PATCH net v3 2/3] xen-netback: don't stop dealloc kthread too early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Aug 2014 15:55:08 +0100
From:	Zoltan Kiss <zoltan.kiss@...rix.com>
To:	Wei Liu <wei.liu2@...rix.com>, <xen-devel@...ts.xen.org>,
	<netdev@...r.kernel.org>
CC:	<ian.campbell@...rix.com>
Subject: Re: [PATCH net v3 2/3] xen-netback: don't stop dealloc kthread too
 early

On 11/08/14 11:11, Wei Liu wrote:
> @@ -1525,10 +1537,13 @@ static int xenvif_handle_frag_list(struct xenvif_queue *queue, struct sk_buff *s
>   	/* remove traces of mapped pages and frag_list */
>   	skb_frag_list_init(skb);
>   	uarg = skb_shinfo(skb)->destructor_arg;
> +	/* See comment on set_skb_zerocopy */
> +	if (uarg->callback == xenvif_zerocopy_callback)
This condition is not necessary: uarg->callback shouldn't be anything 
else but this xenvif_zerocopy_callback at this point, unless something 
terribly went wrong. In that case we are doomed anyway :)

> +		xenvif_inc_inflight_packets(queue);
>   	uarg->callback(uarg, true);
>   	skb_shinfo(skb)->destructor_arg = NULL;
>
> -	skb_shinfo(nskb)->tx_flags |= SKBTX_DEV_ZEROCOPY;
> +	set_skb_zerocopy(queue, nskb);
>   	kfree_skb(nskb);
>
>   	return 0;

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html