lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 Aug 2014 13:07:15 -0400 From: James Smart <james.smart@...lex.com> To: Daniel Borkmann <dborkman@...hat.com> CC: <davem@...emloft.net>, <netdev@...r.kernel.org>, James Bottomley <JBottomley@...allels.com>, "Smart, James" <James.Smart@...lex.Com>, "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org> Subject: Re: [PATCH net-next 2/2] random32: do not feed jiffies as seed from lpfc driver Acked-by: James Smart <james.smart@...lex.com> -- james s On 7/31/2014 4:08 PM, Daniel Borkmann wrote: > In prandom we have already reseeding mechanisms that trigger > periodically from a much better entropy source than just > feeding in jiffies through lpfc_mbx_cmpl_fcf_scan_read_fcf_rec() > [what a function name 8-)]. Therefore, just remove this. > > Signed-off-by: Daniel Borkmann <dborkman@...hat.com> > Cc: James Bottomley <JBottomley@...allels.com> > Cc: James Smart <james.smart@...lex.com> > --- > This can also go via James, how you prefer it. > > drivers/scsi/lpfc/lpfc_hbadisc.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c > index 2a17e31..5072bb2 100644 > --- a/drivers/scsi/lpfc/lpfc_hbadisc.c > +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c > @@ -2146,7 +2146,6 @@ lpfc_mbx_cmpl_fcf_scan_read_fcf_rec(struct lpfc_hba *phba, LPFC_MBOXQ_t *mboxq) > uint16_t fcf_index, next_fcf_index; > struct lpfc_fcf_rec *fcf_rec = NULL; > uint16_t vlan_id; > - uint32_t seed; > bool select_new_fcf; > int rc; > > @@ -2383,9 +2382,6 @@ lpfc_mbx_cmpl_fcf_scan_read_fcf_rec(struct lpfc_hba *phba, LPFC_MBOXQ_t *mboxq) > phba->fcf.fcf_flag |= FCF_AVAILABLE; > /* Setup initial running random FCF selection count */ > phba->fcf.eligible_fcf_cnt = 1; > - /* Seeding the random number generator for random selection */ > - seed = (uint32_t)(0xFFFFFFFF & jiffies); > - prandom_seed(seed); > } > spin_unlock_irq(&phba->hbalock); > goto read_next_fcf; -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists