netdev - Re: [PATCH v2 net] net: Always untag vlan-tagged traffic on input.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140811.121726.433178704630420349.davem@davemloft.net>
Date:	Mon, 11 Aug 2014 12:17:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	vyasevic@...hat.com
Cc:	netdev@...r.kernel.org, kaber@...sh.net, nsujir@...adcom.com,
	mchan@...adcom.com, jiri@...nulli.us
Subject: Re: [PATCH v2 net] net: Always untag vlan-tagged traffic on input.

From: Vladislav Yasevich <vyasevic@...hat.com>
Date: Fri,  8 Aug 2014 14:42:13 -0400

> Currently the functionality to untag traffic on input resides
> as part of the vlan module and is build only when VLAN support
> is enabled in the kernel.  When VLAN is disabled, the function
> vlan_untag() turns into a stub and doesn't really untag the
> packets.  This seems to create an interesting interaction
> between VMs supporting checksum offloading and some network drivers.
 ...
> The patch attempt to fix this another way.  It moves the vlan header
> stipping code out of the vlan module and always builds it into the
> kernel network core.  This way, even if vlan is not supported on
> a virtualizatoin host, the virtual machines running on top of such
> host will still work with VLANs enabled.
> 
> CC: Patrick McHardy <kaber@...sh.net>
> CC: Nithin Nayak Sujir <nsujir@...adcom.com>
> CC: Michael Chan <mchan@...adcom.com>
> CC: Jiri Pirko <jiri@...nulli.us>
> Signed-off-by: Vladislav Yasevich <vyasevic@...hat.com>

Applied and queued up for -stable, thanks Vlad.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html