netdev - Re: [PATCH v2] myri10ge: check for DMA mapping errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53E9E6A8.2060908@myricom.com>
Date:	Tue, 12 Aug 2014 19:04:24 +0900
From:	Hyong-Youb Kim <hyong-youb.kim@...icom.com>
To:	Stanislaw Gruszka <sgruszka@...hat.com>, <netdev@...r.kernel.org>
CC:	Hyong-Youb Kim <hykim@...i.com>
Subject: Re: [PATCH v2] myri10ge: check for DMA mapping errors


On 8/12/2014 5:35 PM, Stanislaw Gruszka wrote:
> On IOMMU systems DMA mapping can fail, we need to check for
> that possibility.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@...hat.com>
> ---
> v1 -> v2: check also for errors on myri10ge_xmit()

It looks okay to me.

>   abort_linearize:
[...]
> -	tx->info[idx].skb = NULL;

I think this last line was a bug.  Thanks for fixing this too.  It would 
lead the code below to call pci_unmap_page() on the header buffer.  It 
should call pci_unmap_single() instead.

> -	do {
[...]
> -			if (tx->info[idx].skb != NULL)
> -				pci_unmap_single(mgp->pdev,
[...]
> -			else
> -				pci_unmap_page(mgp->pdev,
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html