netdev - Re: [PATCH net v4 0/3] xen-netback: synchronisation between core driver and netback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53EA469A.5030008@citrix.com>
Date:	Tue, 12 Aug 2014 17:53:46 +0100
From:	Zoltan Kiss <zoltan.kiss@...rix.com>
To:	Wei Liu <wei.liu2@...rix.com>, <xen-devel@...ts.xen.org>,
	<netdev@...r.kernel.org>
CC:	<ian.campbell@...rix.com>, <david.vrabel@...rix.com>
Subject: Re: [PATCH net v4 0/3] xen-netback: synchronisation between core
 driver and netback

On 12/08/14 11:48, Wei Liu wrote:
> The zero-copy netback has far more interactions with core network driver than
> the old copying backend. One significant thing is that netback now relies on
> a callback from core driver to correctly release resources.
>
> However correct synchronisation between core driver and netback is missing.
> Currently netback relies on a loop to wait for core driver to release
> resources. This is proven not enough and erroneous recently, partly due to code
> structure, partly due to missing synchronisation. Short-live domains like
> OpenMirage unikernels can easily trigger race in backend, rendering backend
> unresponsive.
>
> This patch series aims to slove this issue by introducing proper
> synchronisation between core driver and netback.
>
> Wei.
>
> Chagges in v4:
> * avoid using wait queue
> * remove dedicated loop for netif_napi_del
> * remove unnecessary check on callback
>
> Change in v3: improve commit message in patch 1
>
> Change in v2: fix Zoltan's email address in commit message
>
>
> Wei Liu (3):
>    xen-netback: move NAPI add/remove calls
>    xen-netback: don't stop dealloc kthread too early
>    xen-netback: remove loop waiting function
>
>   drivers/net/xen-netback/common.h    |    5 ++++
>   drivers/net/xen-netback/interface.c |   56 ++++++++++++++---------------------
>   drivers/net/xen-netback/netback.c   |   26 +++++++++++-----
>   3 files changed, 47 insertions(+), 40 deletions(-)
>

Looks good for me.

Acked-by: Zoltan Kiss <zoltan.kiss@...rix.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html