netdev - Re: [PATCH net-next 0/6] Trivial fixes for cxgb4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140812.142023.190072605686378631.davem@davemloft.net>
Date:	Tue, 12 Aug 2014 14:20:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hariprasad@...lsio.com
Cc:	netdev@...r.kernel.org, leedom@...lsio.com, nirranjan@...lsio.com,
	kumaras@...lsio.com, anish@...lsio.com
Subject: Re: [PATCH net-next 0/6] Trivial fixes for cxgb4

From: Hariprasad Shenai <hariprasad@...lsio.com>
Date: Tue, 12 Aug 2014 11:09:07 +0530

> This patch series adds support to fix T5 adapter accessing T4
> adapter registers, issue mbox command on correct mbox for physical
> function, avoid dumping write only registers, use correct length for
> adapter part number and support to detect and display firmware
> reported errors.
> 
> The patches series is created against 'net-next' tree.
> And includes patches on cxgb4 driver.
> 
> We have included all the maintainers of respective drivers. Kindly review the
> change and let us know in case of any review comments.

If these are bug fixes why are you not targetting the 'net' tree?

Secondly, your commit messages are too terse.  For example, in patch
#1 you just say "Fix for handling 1Gb/s SFP+ Transceiver Modules"
which doesn't tell anyone reading the change what the problem was.

What needed to be fixed?  What wasn't being done correctly and how
is it being fixed?

You can't just say "Fix xxx", that doesn't tell the reader anything.
You can say "Fix xxx" in the commit message header line, but then
you have to go into detail about the issue in the commit message
body.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html